On Wed, May 21, 2014 at 5:01 PM, Ryan Wilson 76511 <wr...@vmware.com> wrote: > Some inline comments below. The only thing I'm a bit concerned about it is > the constant cast issue, especially since created / modified are actually > altered in modify_group(). > > Also, the problem is the struct-defined variables are constant, so > CONST_CAST won't work here. (CONST_CAST works for converting constant > variables to non-constant variables). Obviously, I could initialize a > pointer to the constant variable and overwrite the pointer's value in > init_group. But this will make the code somewhat ugly for a minor gain. >
I don't think we have to solve it for this patch. It is not essential to the correctness, but a nice thing if can be pulled off. I will take a closer look later. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
