Re: [ovs-dev] [PATCH v5 2/4] dpif-netdev: Do not check mask if it doesn't exist.

2013-12-06 Thread Jarno Rajahalme
> On Dec 6, 2013, at 3:42 PM, Ben Pfaff wrote: > >> On Thu, Dec 05, 2013 at 04:27:24PM -0800, Jarno Rajahalme wrote: >> Ofproto always provides a valid pointer to a mask, but the mask length >> is zero when megaflows are disabled. Use match_wc_init() to get an >> appropriate exact match mask wh

Re: [ovs-dev] [PATCH v5 2/4] dpif-netdev: Do not check mask if it doesn't exist.

2013-12-06 Thread Ben Pfaff
On Thu, Dec 05, 2013 at 04:27:24PM -0800, Jarno Rajahalme wrote: > Ofproto always provides a valid pointer to a mask, but the mask length > is zero when megaflows are disabled. Use match_wc_init() to get an > appropriate exact match mask when there is no mask. > > Signed-off-by: Jarno Rajahalme

Re: [ovs-dev] [PATCH v5 2/4] dpif-netdev: Do not check mask if it doesn't exist.

2013-12-06 Thread Jarno Rajahalme
On Dec 6, 2013, at 12:53 PM, Ben Pfaff wrote: > On Fri, Dec 06, 2013 at 11:48:58AM -0800, Jarno Rajahalme wrote: >> >> On Dec 6, 2013, at 9:40 AM, Ben Pfaff wrote: >> >>> On Thu, Dec 05, 2013 at 04:27:24PM -0800, Jarno Rajahalme wrote: Ofproto always provides a valid pointer to a mask, b

Re: [ovs-dev] [PATCH v5 2/4] dpif-netdev: Do not check mask if it doesn't exist.

2013-12-06 Thread Ben Pfaff
On Fri, Dec 06, 2013 at 11:48:58AM -0800, Jarno Rajahalme wrote: > > On Dec 6, 2013, at 9:40 AM, Ben Pfaff wrote: > > > On Thu, Dec 05, 2013 at 04:27:24PM -0800, Jarno Rajahalme wrote: > >> Ofproto always provides a valid pointer to a mask, but the mask length > >> is zero when megaflows are dis

Re: [ovs-dev] [PATCH v5 2/4] dpif-netdev: Do not check mask if it doesn't exist.

2013-12-06 Thread Jarno Rajahalme
On Dec 6, 2013, at 9:40 AM, Ben Pfaff wrote: > On Thu, Dec 05, 2013 at 04:27:24PM -0800, Jarno Rajahalme wrote: >> Ofproto always provides a valid pointer to a mask, but the mask length >> is zero when megaflows are disabled. Use match_wc_init() to get an >> appropriate exact match mask when th

Re: [ovs-dev] [PATCH v5 2/4] dpif-netdev: Do not check mask if it doesn't exist.

2013-12-06 Thread Ben Pfaff
On Thu, Dec 05, 2013 at 04:27:24PM -0800, Jarno Rajahalme wrote: > Ofproto always provides a valid pointer to a mask, but the mask length > is zero when megaflows are disabled. Use match_wc_init() to get an > appropriate exact match mask when there is no mask. I'm having a little trouble understa

[ovs-dev] [PATCH v5 2/4] dpif-netdev: Do not check mask if it doesn't exist.

2013-12-05 Thread Jarno Rajahalme
Ofproto always provides a valid pointer to a mask, but the mask length is zero when megaflows are disabled. Use match_wc_init() to get an appropriate exact match mask when there is no mask. Signed-off-by: Jarno Rajahalme --- v5: - Split dpif_netdev_flow_mask_from_nlattrs() to dpif_netdev_f