> On Dec 6, 2013, at 3:42 PM, Ben Pfaff <b...@nicira.com> wrote: > >> On Thu, Dec 05, 2013 at 04:27:24PM -0800, Jarno Rajahalme wrote: >> Ofproto always provides a valid pointer to a mask, but the mask length >> is zero when megaflows are disabled. Use match_wc_init() to get an >> appropriate exact match mask when there is no mask. >> >> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com> > > Does match_wc_init() have the semantics we want? I would have guessed > that we want to match on every field, or at least every field that is > well-defined by prerequisites, rather than on every field that is > nonzero. >
I thought it was doing that... Should have been more careful. Also, it would be better to have only one kind of mask, as the classifier performs better in that case. > I am less and less sure that match_wc_init() makes sense for anything > other than display to a user. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
