Re: [ovs-dev] [PATCH v5 04/13] lib: Unify flags parsing and formatting.

2014-09-08 Thread Jarno Rajahalme
Thanks for the review, pushed to master, Jarno On Sep 8, 2014, at 2:34 PM, Ben Pfaff wrote: > On Fri, Sep 05, 2014 at 04:05:11PM -0700, Jarno Rajahalme wrote: >> Use the "+-" syntax more uniformly when printing masked flags, and use >> the syntax of delimited 1-flags also for formatting fully

Re: [ovs-dev] [PATCH v5 04/13] lib: Unify flags parsing and formatting.

2014-09-08 Thread Ben Pfaff
On Fri, Sep 05, 2014 at 04:05:11PM -0700, Jarno Rajahalme wrote: > Use the "+-" syntax more uniformly when printing masked flags, and use > the syntax of delimited 1-flags also for formatting fully masked TCP > flags. > > The "+-" syntax only deals with masked flags, but if there are many of > tho

[ovs-dev] [PATCH v5 04/13] lib: Unify flags parsing and formatting.

2014-09-05 Thread Jarno Rajahalme
Use the "+-" syntax more uniformly when printing masked flags, and use the syntax of delimited 1-flags also for formatting fully masked TCP flags. The "+-" syntax only deals with masked flags, but if there are many of those, the printout becomes long and confusing. Typically there are many flags