On Fri, Sep 05, 2014 at 04:05:11PM -0700, Jarno Rajahalme wrote:
> Use the "+-" syntax more uniformly when printing masked flags, and use
> the syntax of delimited 1-flags also for formatting fully masked TCP
> flags.
>
> The "+-" syntax only deals with masked flags, but if there are many of
> those, the printout becomes long and confusing. Typically there are
> many flags only when flags are fully masked, but even then most of
> them are zeros, so it makes sense to print the flags that are set
> (ones) and omit the zero flags.
>
> Signed-off-by: Jarno Rajahalme <[email protected]>
I'd be inclined to just use "0" here:
+ } else {
+ ds_put_cstr(s, "0x000"); /* Zero flags. */
+ }
Acked-by: Ben Pfaff <[email protected]>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
