Re: [ovs-dev] [PATCH v4 01/12] ofproto: Rename *_begin functions as *_start.

2015-06-10 Thread Jarno Rajahalme
> On Jun 10, 2015, at 9:22 AM, Ben Pfaff wrote: > > On Tue, Jun 09, 2015 at 05:24:08PM -0700, Jarno Rajahalme wrote: >> Weirdest things can bother you at night when you try to sleep ;-) >> >> Now we have function triples such as add_flow_begin(), >> add_flow_finish(), and add_flow_revert(), whe

Re: [ovs-dev] [PATCH v4 01/12] ofproto: Rename *_begin functions as *_start.

2015-06-10 Thread Ben Pfaff
On Tue, Jun 09, 2015 at 05:24:08PM -0700, Jarno Rajahalme wrote: > Weirdest things can bother you at night when you try to sleep ;-) > > Now we have function triples such as add_flow_begin(), > add_flow_finish(), and add_flow_revert(), where a modification is > started in *_begin(), which can fail

[ovs-dev] [PATCH v4 01/12] ofproto: Rename *_begin functions as *_start.

2015-06-09 Thread Jarno Rajahalme
Weirdest things can bother you at night when you try to sleep ;-) Now we have function triples such as add_flow_begin(), add_flow_finish(), and add_flow_revert(), where a modification is started in *_begin(), which can fail, and when successful can be either made permanent with *_finish(), or canc