> On Jun 10, 2015, at 9:22 AM, Ben Pfaff <b...@nicira.com> wrote: > > On Tue, Jun 09, 2015 at 05:24:08PM -0700, Jarno Rajahalme wrote: >> Weirdest things can bother you at night when you try to sleep ;-) >> >> Now we have function triples such as add_flow_begin(), >> add_flow_finish(), and add_flow_revert(), where a modification is >> started in *_begin(), which can fail, and when successful can be >> either made permanent with *_finish(), or cancelled with *_revert(). >> >> Linguistically it should be either "begin/end" or "start/finish", not >> "begin/finish". "begin/end" has some C++ STL baggage, so let's go >> with "start/finish". IMO "revert" rhymes with it, too. >> >> Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com> > > Acked-by: Ben Pfaff <b...@nicira.com>
Thanks for the review! Pushed to master, Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
