Re: [ovs-dev] [PATCH v3 7/8] Support NTR selection method in ovs-ofctl group commands

2015-03-18 Thread Ben Pfaff
On Thu, Mar 19, 2015 at 08:35:14AM +0900, Simon Horman wrote: > On Tue, Mar 17, 2015 at 03:25:36PM -0700, Ben Pfaff wrote: > > On Mon, Mar 09, 2015 at 10:11:02AM +0900, Simon Horman wrote: > > I think that the documentation should mention that these new features > > are only available in OVS 2.4 an

Re: [ovs-dev] [PATCH v3 7/8] Support NTR selection method in ovs-ofctl group commands

2015-03-18 Thread Simon Horman
On Tue, Mar 17, 2015 at 03:25:36PM -0700, Ben Pfaff wrote: > On Mon, Mar 09, 2015 at 10:11:02AM +0900, Simon Horman wrote: > > NTR selection method > > Signed-off-by: Simon Horman > > Thank you for the patch! > > Since a mask is not allowed, I would expect parse_select_group_field() > to call mf

Re: [ovs-dev] [PATCH v3 7/8] Support NTR selection method in ovs-ofctl group commands

2015-03-17 Thread Ben Pfaff
On Mon, Mar 09, 2015 at 10:11:02AM +0900, Simon Horman wrote: > NTR selection method > Signed-off-by: Simon Horman Thank you for the patch! Since a mask is not allowed, I would expect parse_select_group_field() to call mf_parse_value() rather than mf_parse(). I think that the documentation shou

[ovs-dev] [PATCH v3 7/8] Support NTR selection method in ovs-ofctl group commands

2015-03-08 Thread Simon Horman
NTR selection method Signed-off-by: Simon Horman --- v3 * Use fixed array for fields_array rather than constructing a list * Use NTR instead of NMX as Netronome extension prefix v2 * Use list of struct field_array of TLVs rather than OF1.1 match for fields field of NTR selection method proper