On Mon, Mar 09, 2015 at 10:11:02AM +0900, Simon Horman wrote: > NTR selection method > Signed-off-by: Simon Horman <simon.hor...@netronome.com>
Thank you for the patch! Since a mask is not allowed, I would expect parse_select_group_field() to call mf_parse_value() rather than mf_parse(). I think that the documentation should mention that these new features are only available in OVS 2.4 and up and only with OpenFlow 1.5 and up and use a Netronome extension to OpenFlow. In parse_ofp_group_mod_str__(), I think that '0' here should be either 0 or '\0': + memset(gm->props.selection_method, '0', + NTR_MAX_SELECTION_METHOD_LEN); Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
