Re: [ovs-dev] [PATCH v3 1/7] lib: Add IGMP snooping library bits

2014-06-12 Thread Ben Pfaff
On Thu, Jun 12, 2014 at 04:51:20PM -0300, Flavio Leitner wrote: > I didn't like much the OVS_FORCE change, but indeed it's cheaper > than calling ntohl() and I don't have a better suggestion. We use OVS_FORCE for hashing big-endian data elsewhere, so it's somewhat idiomatic in the OVS code base.

Re: [ovs-dev] [PATCH v3 1/7] lib: Add IGMP snooping library bits

2014-06-12 Thread Flavio Leitner
On Wed, Jun 11, 2014 at 11:20:40AM -0700, Ben Pfaff wrote: > On Sat, May 31, 2014 at 01:53:15AM -0300, Flavio Leitner wrote: > > This patch adds generic IGMP snooping library code > > that is used in follow-up patches. > > > > Signed-off-by: Cong Wang > > Signed-off-by: Daniel Borkmann > > Acked

Re: [ovs-dev] [PATCH v3 1/7] lib: Add IGMP snooping library bits

2014-06-11 Thread Ben Pfaff
On Sat, May 31, 2014 at 01:53:15AM -0300, Flavio Leitner wrote: > This patch adds generic IGMP snooping library code > that is used in follow-up patches. > > Signed-off-by: Cong Wang > Signed-off-by: Daniel Borkmann > Acked-by: Thomas Graf > Signed-off-by: Flavio Leitner Thanks for the revisi

[ovs-dev] [PATCH v3 1/7] lib: Add IGMP snooping library bits

2014-05-30 Thread Flavio Leitner
This patch adds generic IGMP snooping library code that is used in follow-up patches. Signed-off-by: Cong Wang Signed-off-by: Daniel Borkmann Acked-by: Thomas Graf Signed-off-by: Flavio Leitner --- lib/automake.mk | 2 + lib/mcast-snooping.c | 759 ++