Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-03-31 Thread Jesse Gross
On Sat, Mar 29, 2014 at 7:33 PM, Jarno Rajahalme wrote: > > On Mar 28, 2014, at 2:52 PM, Jesse Gross wrote: > >> On Fri, Mar 28, 2014 at 8:50 AM, Jarno Rajahalme >> wrote: >>> On Mar 27, 2014, at 3:59 PM, Jesse Gross wrote: > On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme >>

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-03-29 Thread Jarno Rajahalme
On Mar 28, 2014, at 2:52 PM, Jesse Gross wrote: > On Fri, Mar 28, 2014 at 8:50 AM, Jarno Rajahalme > wrote: >> >>> On Mar 27, 2014, at 3:59 PM, Jesse Gross wrote: >>> On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme wrote: Minimize padding in sw_flow_key and move 'tp' top

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-03-28 Thread Jesse Gross
On Fri, Mar 28, 2014 at 8:50 AM, Jarno Rajahalme wrote: > >> On Mar 27, 2014, at 3:59 PM, Jesse Gross wrote: >> >>> On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme >>> wrote: >>> Minimize padding in sw_flow_key and move 'tp' top the main struct. >>> These changes simplify code when accessing

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-03-28 Thread Jarno Rajahalme
> On Mar 27, 2014, at 3:59 PM, Jesse Gross wrote: > >> On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme >> wrote: >> Minimize padding in sw_flow_key and move 'tp' top the main struct. >> These changes simplify code when accessing the transport port numbers >> and the tcp flags, and makes the

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-03-27 Thread Jesse Gross
On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme wrote: > Minimize padding in sw_flow_key and move 'tp' top the main struct. > These changes simplify code when accessing the transport port numbers > and the tcp flags, and makes the sw_flow_key 8 bytes smaller on 64-bit > systems (128->120 bytes).

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-03-24 Thread Jarno Rajahalme
Pushed to master, Some comments below, Jarno On Mar 24, 2014, at 10:26 AM, Pravin Shelar wrote: > On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme > wrote: >> Minimize padding in sw_flow_key and move 'tp' top the main struct. >> These changes simplify code when accessing the transport por

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-03-24 Thread Pravin Shelar
On Fri, Feb 21, 2014 at 11:41 AM, Jarno Rajahalme wrote: > Minimize padding in sw_flow_key and move 'tp' top the main struct. > These changes simplify code when accessing the transport port numbers > and the tcp flags, and makes the sw_flow_key 8 bytes smaller on 64-bit > systems (128->120 bytes).

Re: [ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-02-24 Thread Jarno Rajahalme
On Feb 21, 2014, at 11:41 AM, Jarno Rajahalme wrote: > Minimize padding in sw_flow_key and move 'tp' top the main struct. > These changes simplify code when accessing the transport port numbers > and the tcp flags, and makes the sw_flow_key 8 bytes smaller on 64-bit > systems (128->120 bytes).

[ovs-dev] [PATCH v3 04/10] datapath: Compact sw_flow_key.

2014-02-21 Thread Jarno Rajahalme
Minimize padding in sw_flow_key and move 'tp' top the main struct. These changes simplify code when accessing the transport port numbers and the tcp flags, and makes the sw_flow_key 8 bytes smaller on 64-bit systems (128->120 bytes). These changes also make the keys for IPv4 packets to fit in one