>> As you know, the Windows kernel is synchronous in terms of netlink
>> messages. Transaction semantics are implemented in one call that
>> includes both the “request” and the “reply” in one shot. So, if
>> there’s a mismatch, it implies the kernel bungled the ‘nlmsg_seq’. So,
>> the assert was ad
>> I agree with your comment.
>>
>> The error handling was in place since we were doing the whole “netlink
>> emulation” with any OS support unlike Linux, and we wanted to catch issues
>> in release builds also.
>>
>> If you are not very particular, can I let the code be? Once the code matures
On Wed, Apr 29, 2015 at 03:41:00PM +, Nithin Raju wrote:
> >> As you know, the Windows kernel is synchronous in terms of netlink
> >> messages. Transaction semantics are implemented in one call that
> >> includes both the “request” and the “reply” in one shot. So, if
> >> there’s a mismatch, it
] [PATCH v3] ovs-hyperv: make kernel return values netlink
socket like
On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote:
> In this patch, we make changes to usersapce as well as kernel datapath
> on hyperv to make it more netlink socket like. Previously, the kernel
> datapat
Besides that LG.
Thanks,
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, April 29, 2015 7:38 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink
socket like
Thanks for the review.
> On Apr 29, 2
On Wed, Apr 29, 2015 at 02:50:24PM +, Nithin Raju wrote:
> > On Apr 29, 2015, at 7:45 AM, Ben Pfaff wrote:
> >
> > On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote:
> >> In this patch, we make changes to usersapce as well as
> >> kernel datapath on hyperv to make it more netlink so
> On Apr 29, 2015, at 7:45 AM, Ben Pfaff wrote:
>
> On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote:
>> In this patch, we make changes to usersapce as well as
>> kernel datapath on hyperv to make it more netlink socket
>> like. Previously, the kernel datapath did not distinguish
>> be
Thanks for the review.
> On Apr 29, 2015, at 6:06 AM, Eitan Eliahu wrote:
>
>
> Hi Nithin,
> Sorry, I come late on this one, change looks good.
>
> We need to check if the IRP output buffer is big enough to fit the
> transaction message before copying it. Otherwise, we need to return error an
On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote:
> In this patch, we make changes to usersapce as well as
> kernel datapath on hyperv to make it more netlink socket
> like. Previously, the kernel datapath did not distinguish
> between "transport errors" and other errors. Netlink
> seman
[mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
Sent: Tuesday, April 28, 2015 2:36 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink
socket like
In this patch, we make changes to usersapce as well as kernel datapath on
hyperv to make
In this patch, we make changes to usersapce as well as
kernel datapath on hyperv to make it more netlink socket
like. Previously, the kernel datapath did not distinguish
between "transport errors" and other errors. Netlink
semantics dictate that netlink functions should only
return an error only in
11 matches
Mail list logo
