Re: [ovs-dev] [PATCH v3] ofp-actions: Implement writing to metadata field

2012-08-17 Thread Ben Pfaff
On Fri, Aug 17, 2012 at 08:42:53PM +1200, Joe Stringer wrote: > On 16 August 2012 06:43, Ben Pfaff wrote: > > On Wed, Aug 15, 2012 at 12:28:47AM +1200, Joe Stringer wrote: > >> In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to > >> write to the metadata field. Internally

Re: [ovs-dev] [PATCH v3] ofp-actions: Implement writing to metadata field

2012-08-17 Thread Joe Stringer
On 16 August 2012 06:43, Ben Pfaff wrote: > On Wed, Aug 15, 2012 at 12:28:47AM +1200, Joe Stringer wrote: >> In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to >> write to the metadata field. Internally it is represented using >> ofpact_metadata. >> >> We introduce NXAST_

Re: [ovs-dev] [PATCH v3] ofp-actions: Implement writing to metadata field

2012-08-15 Thread Ben Pfaff
On Wed, Aug 15, 2012 at 12:28:47AM +1200, Joe Stringer wrote: > In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to > write to the metadata field. Internally it is represented using > ofpact_metadata. > > We introduce NXAST_WRITE_METADATA to handle writing to the metadata

Re: [ovs-dev] [PATCH v3] ofp-actions: Implement writing to metadata field

2012-08-14 Thread Isaku Yamahata
Basically it looks good. One minor comment inline. On Wed, Aug 15, 2012 at 12:28:47AM +1200, Joe Stringer wrote: > diff --git a/lib/ofp-actions.h b/lib/ofp-actions.h > index 272b8e8..a16c04a 100644 > --- a/lib/ofp-actions.h > +++ b/lib/ofp-actions.h ... > @@ -311,6 +311,15 @@ struct ofpact_fin_tim

[ovs-dev] [PATCH v3] ofp-actions: Implement writing to metadata field

2012-08-14 Thread Joe Stringer
In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. Wh