Re: [ovs-dev] [PATCH v3] checkpatch.py: A simple script for finding patch issues

2016-03-30 Thread Ben Pfaff
On Wed, Mar 30, 2016 at 03:50:33PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Thu, Mar 24, 2016 at 05:45:40PM -0400, Aaron Conole wrote: > >> Most projects have a checkpatch facility, which can be used as a pre-commit > >> sanity check. This introduces such a mechanism to the Open vS

Re: [ovs-dev] [PATCH v3] checkpatch.py: A simple script for finding patch issues

2016-03-30 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Mar 24, 2016 at 05:45:40PM -0400, Aaron Conole wrote: >> Most projects have a checkpatch facility, which can be used as a pre-commit >> sanity check. This introduces such a mechanism to the Open vSwitch project >> to catch some of the more silly formatting mistakes whi

Re: [ovs-dev] [PATCH v3] checkpatch.py: A simple script for finding patch issues

2016-03-30 Thread Ben Pfaff
On Thu, Mar 24, 2016 at 05:45:40PM -0400, Aaron Conole wrote: > Most projects have a checkpatch facility, which can be used as a pre-commit > sanity check. This introduces such a mechanism to the Open vSwitch project > to catch some of the more silly formatting mistakes which can occur. It is > not

[ovs-dev] [PATCH v3] checkpatch.py: A simple script for finding patch issues

2016-03-24 Thread Aaron Conole
Most projects have a checkpatch facility, which can be used as a pre-commit sanity check. This introduces such a mechanism to the Open vSwitch project to catch some of the more silly formatting mistakes which can occur. It is not meant to replace good code review practices, but it can help eliminat