On Wed, Mar 30, 2016 at 03:50:33PM -0400, Aaron Conole wrote:
> Ben Pfaff <[email protected]> writes:
>
> > On Thu, Mar 24, 2016 at 05:45:40PM -0400, Aaron Conole wrote:
> >> Most projects have a checkpatch facility, which can be used as a pre-commit
> >> sanity check. This introduces such a mechanism to the Open vSwitch project
> >> to catch some of the more silly formatting mistakes which can occur. It is
> >> not meant to replace good code review practices, but it can help eliminate
> >> the silly code review issues which get added.
> >>
> >> Suggested-by: Mauricio Vásquez <[email protected]>
> >> Signed-off-by: Aaron Conole <[email protected]>
> >> ---
> >> v2:
> >> - Moved to the utilities directory
> >> - Fixed up according to flake8
> >> - Added an ignore for leading tabs with .mk file modifications
> >> - hooked up the return values
> >>
> >> v3:
> >> - Added to EXTRA_DIST
> >> - Made it executable
> >> - Support `git show | ./utilities/checkpatch.py`
> >> - Added help text
> >> - Added the ability to turn off most of the tests (except line-length)
> >> - Amended CONTRIBUTING.md to also note to use linux checkpatch.pl for
> >> datapath
> >
> > This seems potentially useful, especially if it is enhanced over time to
> > add more tests.
> >
> > It looks for various kinds of tags and counts them as 'extra_people',
> > but I don't see anything that actually uses that count. Is there
> > something missing there?
>
> No, they're not useful at the moment; I was considering a case where we
> could turn on a flag and it would complain unless there was at least 1,
> but it is probably not that useful, so I can spin a v4 without this
> check if desired.
Please.
An issue I see from time to time is too many Signed-off-bys. There are
situations where a patch can go through multiple steps on the way into a
project, but in OVS ordinarily this invariant holds:
* Each author (as maintained by Git) and co-author (as in
Co-authored-by) name and email should be in a Signed-off-by
tag.
* There should be exactly one more Signed-off-by tag than
Co-authored-by tags.
It would be handy to check for that.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
