Re: [ovs-dev] [PATCH v3] Genericize/simplify kernel sFlow implementation

2011-09-22 Thread Ben Pfaff
On Thu, Sep 22, 2011 at 04:49:33PM -0700, Neil McKee wrote: > > On Sep 22, 2011, at 4:07 PM, Pravin Shelar wrote: > > > On Thu, Sep 22, 2011 at 1:56 PM, Ben Pfaff wrote: > >> It's not so great to have to call netdev_get_stats() for every sflow > >> packet we send. Maybe we could rate-limit the

Re: [ovs-dev] [PATCH v3] Genericize/simplify kernel sFlow implementation

2011-09-22 Thread Neil McKee
On Sep 22, 2011, at 4:07 PM, Pravin Shelar wrote: > On Thu, Sep 22, 2011 at 1:56 PM, Ben Pfaff wrote: >> On Wed, Sep 21, 2011 at 03:21:46PM -0700, Pravin Shelar wrote: >>> v3: Fixed according to comments from Ben >>> - Probability calculation >>> - Coding style fixes >>> - Now SAM

Re: [ovs-dev] [PATCH v3] Genericize/simplify kernel sFlow implementation

2011-09-22 Thread Ben Pfaff
On Thu, Sep 22, 2011 at 04:07:46PM -0700, Pravin Shelar wrote: > On Thu, Sep 22, 2011 at 1:56 PM, Ben Pfaff wrote: > > On Wed, Sep 21, 2011 at 03:21:46PM -0700, Pravin Shelar wrote: > > compose_controller_action() leaves some fields uninitialized. > > As other values are only required in case of s

Re: [ovs-dev] [PATCH v3] Genericize/simplify kernel sFlow implementation

2011-09-22 Thread Pravin Shelar
On Thu, Sep 22, 2011 at 1:56 PM, Ben Pfaff wrote: > On Wed, Sep 21, 2011 at 03:21:46PM -0700, Pravin Shelar wrote: >> v3: Fixed according to comments from Ben >>     -  Probability calculation >>     -  Coding style fixes >>     -  Now SAMPLE actions is not optional >>     -  Using offset to fix u

Re: [ovs-dev] [PATCH v3] Genericize/simplify kernel sFlow implementation

2011-09-22 Thread Ben Pfaff
On Wed, Sep 21, 2011 at 03:21:46PM -0700, Pravin Shelar wrote: > v3: Fixed according to comments from Ben > - Probability calculation > - Coding style fixes > - Now SAMPLE actions is not optional > - Using offset to fix user-action-cookie. > > I will post another patch to handl

[ovs-dev] [PATCH v3] Genericize/simplify kernel sFlow implementation

2011-09-21 Thread Pravin Shelar
v3: Fixed according to comments from Ben - Probability calculation - Coding style fixes - Now SAMPLE actions is not optional - Using offset to fix user-action-cookie. I will post another patch to handle mirror output port case for sFlow. --8<--cut here-