Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-21 Thread Jesse Gross
On Wednesday, May 21, 2014, Simon Horman wrote: > On Wed, May 21, 2014 at 01:31:55PM -0700, Jesse Gross wrote: > > On Wed, May 21, 2014 at 8:31 AM, Simon Horman > > > > wrote: > > > On Tue, May 20, 2014 at 07:30:38PM -0700, Jesse Gross wrote: > > >> On Thu, May 15, 2014 at 4:07 PM, Simon Horman

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-21 Thread Simon Horman
On Wed, May 21, 2014 at 01:31:55PM -0700, Jesse Gross wrote: > On Wed, May 21, 2014 at 8:31 AM, Simon Horman wrote: > > On Tue, May 20, 2014 at 07:30:38PM -0700, Jesse Gross wrote: > >> On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote: > >> > diff --git a/datapath/linux/compat/include/linux/ne

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-21 Thread Jesse Gross
On Wed, May 21, 2014 at 8:31 AM, Simon Horman wrote: > On Tue, May 20, 2014 at 07:30:38PM -0700, Jesse Gross wrote: >> On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote: >> > diff --git a/datapath/linux/compat/include/linux/netdevice.h >> > b/datapath/linux/compat/include/linux/netdevice.h >>

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-21 Thread Simon Horman
On Tue, May 20, 2014 at 07:30:38PM -0700, Jesse Gross wrote: > On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote: > > diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c > > index 9ded17c..d9b4485 100644 > > --- a/datapath/linux/compat/gso.c > > +++ b/datapath/linux/compat/gso

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-21 Thread Simon Horman
On Tue, May 20, 2014 at 07:05:28PM -0700, Jesse Gross wrote: > On Tue, May 20, 2014 at 3:48 AM, Simon Horman wrote: > > On Mon, May 19, 2014 at 06:34:05PM -0700, Jesse Gross wrote: > >> On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote: > >> > diff --git a/datapath/actions.c b/datapath/actions.

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-20 Thread Jesse Gross
On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote: > diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c > index 9ded17c..d9b4485 100644 > --- a/datapath/linux/compat/gso.c > +++ b/datapath/linux/compat/gso.c > -#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) > +#if LINUX_VERS

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-20 Thread Jesse Gross
On Tue, May 20, 2014 at 3:48 AM, Simon Horman wrote: > On Mon, May 19, 2014 at 06:34:05PM -0700, Jesse Gross wrote: >> On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote: >> > diff --git a/datapath/actions.c b/datapath/actions.c >> > index 603c7cb..7c3ae0c 100644 >> > --- a/datapath/actions.c >>

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-20 Thread Thomas Graf
On 05/20/14 at 07:02am, Simon Horman wrote: > [PATCH] datapath: 16bit inner_network_header field in struct ovs_gso_cb > > The motivation for this is to create a 16bit hole in struct ovs_gso_cb > which may be used for the inner_protocol field which is needed > for the proposed implementation of com

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-20 Thread Simon Horman
On Mon, May 19, 2014 at 06:34:05PM -0700, Jesse Gross wrote: > I have some miscellaneous comments on things that I noticed, all of > which are pretty small. I will probably have a few more tomorrow but > my hope is that we can get this in soon. > > On Thu, May 15, 2014 at 4:07 PM, Simon Horman wr

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-19 Thread Jesse Gross
I have some miscellaneous comments on things that I noticed, all of which are pretty small. I will probably have a few more tomorrow but my hope is that we can get this in soon. On Thu, May 15, 2014 at 4:07 PM, Simon Horman wrote: > diff --git a/datapath/actions.c b/datapath/actions.c > index 603

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-19 Thread Simon Horman
On Sat, May 17, 2014 at 10:32:24AM +0900, Simon Horman wrote: > On Fri, May 16, 2014 at 03:17:18PM -0700, Jesse Gross wrote: > > On Fri, May 16, 2014 at 2:48 PM, Thomas Graf wrote: > > > On 05/16/14 at 02:29pm, Jesse Gross wrote: > > >> On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote: > > >>

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-16 Thread Simon Horman
On Fri, May 16, 2014 at 03:17:18PM -0700, Jesse Gross wrote: > On Fri, May 16, 2014 at 2:48 PM, Thomas Graf wrote: > > On 05/16/14 at 02:29pm, Jesse Gross wrote: > >> On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote: > >> > On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote: > >> >>

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-16 Thread Jesse Gross
On Fri, May 16, 2014 at 2:48 PM, Thomas Graf wrote: > On 05/16/14 at 02:29pm, Jesse Gross wrote: >> On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote: >> > On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote: >> >> Allow datapath to recognize and extract MPLS labels into flow keys >> >

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-16 Thread Thomas Graf
On 05/16/14 at 02:29pm, Jesse Gross wrote: > On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote: > > On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote: > >> Allow datapath to recognize and extract MPLS labels into flow keys > >> and execute actions which push, pop, and set labels on pa

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-16 Thread Jesse Gross
On Fri, May 16, 2014 at 1:48 AM, Simon Horman wrote: > On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote: >> Allow datapath to recognize and extract MPLS labels into flow keys >> and execute actions which push, pop, and set labels on packets. > > [snip] > >> diff --git a/datapath/linux/

Re: [ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-16 Thread Simon Horman
On Fri, May 16, 2014 at 08:07:07AM +0900, Simon Horman wrote: > Allow datapath to recognize and extract MPLS labels into flow keys > and execute actions which push, pop, and set labels on packets. [snip] > diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h > index b83a4c3..98b

[ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-15 Thread Simon Horman
Hi Jesse, Hi Pravin, Hi All, This patchset makes use of a whitelist to only allow mpls_push actions to be applied to packets with an ethertype where the tag order is well defined and implemented. This avoids the problem of where an MPLS LSE should be added in relation to a VLAN or similar tag. Th

[ovs-dev] [PATCH v2.57] datapath: Add basic MPLS support to kernel

2014-05-15 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer. Cc: Ravi K Cc: Leo Alterman Cc: Isaku Yamahata Cc: Joe Stringer Signed-off-by: Sim