Re: [ovs-dev] [PATCH v2 1/2] netdev_class: Pass a struct ofpbuf * to rx_recv()

2013-12-12 Thread Simon Horman
On Thu, Dec 12, 2013 at 06:01:26PM -0800, Ben Pfaff wrote: > On Fri, Dec 13, 2013 at 09:45:43AM +0900, Simon Horman wrote: > > On Thu, Dec 12, 2013 at 08:11:47AM -0800, Jarno Rajahalme wrote: > > > IMO this patch could go a bit further and have the rx_recv also > > > update the but size to reflect

Re: [ovs-dev] [PATCH v2 1/2] netdev_class: Pass a struct ofpbuf * to rx_recv()

2013-12-12 Thread Ben Pfaff
On Fri, Dec 13, 2013 at 09:45:43AM +0900, Simon Horman wrote: > On Thu, Dec 12, 2013 at 08:11:47AM -0800, Jarno Rajahalme wrote: > > IMO this patch could go a bit further and have the rx_recv also > > update the but size to reflect the number of bytes placed in the > > buffer and maybe change the r

Re: [ovs-dev] [PATCH v2 1/2] netdev_class: Pass a struct ofpbuf * to rx_recv()

2013-12-12 Thread Simon Horman
On Thu, Dec 12, 2013 at 08:11:47AM -0800, Jarno Rajahalme wrote: > IMO this patch could go a bit further and have the rx_recv also update the > but size to reflect the number of bytes placed in the buffer and maybe change > the return value to a normal error code. Hi, I would not be opposed to

Re: [ovs-dev] [PATCH v2 1/2] netdev_class: Pass a struct ofpbuf * to rx_recv()

2013-12-12 Thread Simon Horman
On Thu, Dec 12, 2013 at 09:29:12AM -0800, Ben Pfaff wrote: > On Thu, Dec 12, 2013 at 05:38:58PM +0900, Simon Horman wrote: > > Update the netdev_class so that struct ofpbuf * is passed to rx_recv() > > to provide both the data and size of the data to read a packet into. > > > > This patch should n

Re: [ovs-dev] [PATCH v2 1/2] netdev_class: Pass a struct ofpbuf * to rx_recv()

2013-12-12 Thread Ben Pfaff
On Thu, Dec 12, 2013 at 05:38:58PM +0900, Simon Horman wrote: > Update the netdev_class so that struct ofpbuf * is passed to rx_recv() > to provide both the data and size of the data to read a packet into. > > This patch should not have any behavioural changes. > > This patch is in preparation fo

Re: [ovs-dev] [PATCH v2 1/2] netdev_class: Pass a struct ofpbuf * to rx_recv()

2013-12-12 Thread Jarno Rajahalme
IMO this patch could go a bit further and have the rx_recv also update the but size to reflect the number of bytes placed in the buffer and maybe change the return value to a normal error code. Jarno On Dec 12, 2013, at 12:38 AM, Simon Horman wrote: > Update the netdev_class so that struct

[ovs-dev] [PATCH v2 1/2] netdev_class: Pass a struct ofpbuf * to rx_recv()

2013-12-12 Thread Simon Horman
Update the netdev_class so that struct ofpbuf * is passed to rx_recv() to provide both the data and size of the data to read a packet into. This patch should not have any behavioural changes. This patch is in preparation for the netdev-linux variant of rx_recv() making use of headroom in the stru