On Thu, Dec 12, 2013 at 06:01:26PM -0800, Ben Pfaff wrote: > On Fri, Dec 13, 2013 at 09:45:43AM +0900, Simon Horman wrote: > > On Thu, Dec 12, 2013 at 08:11:47AM -0800, Jarno Rajahalme wrote: > > > IMO this patch could go a bit further and have the rx_recv also > > > update the but size to reflect the number of bytes placed in the > > > buffer and maybe change the return value to a normal error code. > > > > I would not be opposed to that, though I do not that the size is never > > updated (or used?) by the caller, so I don't think it will have much > > effect either way. > > I don't follow your point. netdev_rx_recv() uses the return value to > update the buffer size. I believe Jarno is saying that the > netdev_provider rx_recv functions could do that internally instead. > That seems reasonable to me.
Thanks, I see that now. I will update the API as Jarno suggested. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
