Ankur
From: Nithin Raju
Sent: Wednesday, October 1, 2014 11:34 PM
To: Ankur Sharma
Cc:
Subject: Re: [ovs-dev] [PATCH v1 1/5] datapath-windows: Netlink additional APIs.
On Sep 29, 2014, at 3:34 PM, Ankur Sharma wrote:
> +VOID
> +NlMsgAlignSize(const PNL_MSG_HDR nlh)
>
On Sep 29, 2014, at 3:34 PM, Ankur Sharma wrote:
> +VOID
> +NlMsgAlignSize(const PNL_MSG_HDR nlh)
> +{
> +nlh->nlmsgLen = NLMSG_ALIGN(nlh->nlmsgLen);
One question I have here is what if nlmsgLen ends up being more than the
nlBufLen after adjusting for alignment?
Thanks,
-- Nithin
___
hi Ankur,
Thanks for making the change. Looks good mostly, I had minor comments.
I'll ack the v2.
On Sep 29, 2014, at 3:34 PM, Ankur Sharma wrote:
> In this patch we have added following new APIs.
>
> NlMsgAlignSize => Aligns the size of netlink message.
> NlMsgSetSize => Sets the value of nlm
In this patch we have added following new APIs.
NlMsgAlignSize => Aligns the size of netlink message.
NlMsgSetSize => Sets the value of nlmsgLen.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Netlink/Netlink.c | 54 +++
datapath-windows/ovsext/Netlink/Netli
