Hi Nithin,
Thanks a lot for the review comments.
I agree with all your comments in this patch and will submit a v2 with changes
incorporated.
I'll think over handling the cases in caller of NlMsgAlignSize where post
alignment size exceeds the output buffer.
Regards,
Ankur
________________________________________
From: Nithin Raju
Sent: Wednesday, October 1, 2014 11:34 PM
To: Ankur Sharma
Cc: <dev@openvswitch.org>
Subject: Re: [ovs-dev] [PATCH v1 1/5] datapath-windows: Netlink additional APIs.
On Sep 29, 2014, at 3:34 PM, Ankur Sharma <ankursha...@vmware.com> wrote:
> +VOID
> +NlMsgAlignSize(const PNL_MSG_HDR nlh)
> +{
> + nlh->nlmsgLen = NLMSG_ALIGN(nlh->nlmsgLen);
One question I have here is what if nlmsgLen ends up being more than the
nlBufLen after adjusting for alignment?
Thanks,
-- Nithin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
