Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Ben Pfaff
On Fri, Jun 24, 2016 at 03:50:44AM +, Wenyu Zhang wrote: > On 6/24/16, 10:54 AM, "Wenyu Zhang" wrote: > >On 6/24/16, 2:18 AM, "Ben Pfaff" wrote: > >>The documentation doesn't say what a "virtual observation ID" is. This > >>is not a standard term, so users can't be expected to know. Please

Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Wenyu Zhang
Hi Ben, I add new comments inline . May you take a look? On 6/24/16, 10:54 AM, "Wenyu Zhang" wrote: >Thanks for your inputs. > >I added some comments inline, may you help take a look? > >On 6/24/16, 2:18 AM, "Ben Pfaff" wrote: > >>On Mon, Jun 20, 2016 at 08:54:12PM -0700, Wenyu Zhang wrote: >>

Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Ben Pfaff
On Fri, Jun 24, 2016 at 02:54:23AM +, Wenyu Zhang wrote: > On 6/24/16, 2:18 AM, "Ben Pfaff" wrote: > > >On Mon, Jun 20, 2016 at 08:54:12PM -0700, Wenyu Zhang wrote: > >> In virtual network, users want more info about the virtual point to > >>observe the traffic. > >> It should be a string to

Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Wenyu Zhang
Thanks for your inputs. I added some comments inline, may you help take a look? On 6/24/16, 2:18 AM, "Ben Pfaff" wrote: >On Mon, Jun 20, 2016 at 08:54:12PM -0700, Wenyu Zhang wrote: >> In virtual network, users want more info about the virtual point to >>observe the traffic. >> It should be a s

Re: [ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-23 Thread Ben Pfaff
On Mon, Jun 20, 2016 at 08:54:12PM -0700, Wenyu Zhang wrote: > In virtual network, users want more info about the virtual point to observe > the traffic. > It should be a string to provide clear info, not a simple interger ID. > > Introduce "other-config: virtual_obs_id" in IPFIX, which is a stri

[ovs-dev] [PATCH v1] ipfix: Export user specified virtual observation ID

2016-06-20 Thread Wenyu Zhang
In virtual network, users want more info about the virtual point to observe the traffic. It should be a string to provide clear info, not a simple interger ID. Introduce "other-config: virtual_obs_id" in IPFIX, which is a string configured by user. Introduce an enterprise IPFIX entity "virtual_o