On Fri, Jun 24, 2016 at 03:50:44AM +0000, Wenyu Zhang wrote: > On 6/24/16, 10:54 AM, "Wenyu Zhang" <wen...@vmware.com> wrote: > >On 6/24/16, 2:18 AM, "Ben Pfaff" <b...@ovn.org> wrote: > >>The documentation doesn't say what a "virtual observation ID" is. This > >>is not a standard term, so users can't be expected to know. Please > >>explain. In the end, I think that this is just an extra string that > >>accompanies the flow records, so it may not be worthwhile to invent a > >>special name for it like "virtual observation ID". > >Wenyu: I want to introduce an entity to export the description of > >observation info in virtual network. > > Do you have any suggestion about the entity name ? > Wenyu: I use "virutal_obs_id" in ³other_config", due to the configured > value > Will be emitted with this enterprise entity. We need a key to > set the string, not must be ³virutal_obs_id² but I didn¹t find a > proper one. > Do you mean that we should use a more general key, such as > ³extra-string²?
I do not have a good name in mind, I think that virtual_obs_id is OK, but the documentation should explain what the string is used for. > >>CodingStyle.md explains how to format ?: and how to break expressions > >>across lines, but this patch does not follow this style. > >Wenyu: Thanks for the catch. I will fix it. > > > >> > >>In ipfix_put_data_set(), it is wasteful to use dp_packet_put_zeros() > >>then immediately copy over all of the zeros. > >> > >>In ipfix_put_data_set(), this cast is not needed: > >>+ data_virtual_obs_id->virtual_obs_len = (uint8_t)virtual_obs_len; > >Wenyu: Due to the entity is variable-length, the length of data is > >necessary. > > I may put the byte into msg directly, instead of putting zeros and > >overwrite it. OK. That is fine too. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
