Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-04-03 Thread Kavanagh, Mark B
>On Thu, Apr 02, 2015 at 04:38:13PM +, Kavanagh, Mark B wrote: >> >> >On 04/01/15 at 07:45am, Kavanagh, Mark B wrote: >> >> >> >> >What's wrong with setting CFLAGS on the "configure" or "make" command >> >> >line? This is the standard way to do this with Automake and Autoconf. >> >> > >> >> >>

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-04-02 Thread Ben Pfaff
On Thu, Apr 02, 2015 at 04:38:13PM +, Kavanagh, Mark B wrote: > > >On 04/01/15 at 07:45am, Kavanagh, Mark B wrote: > >> > >> >What's wrong with setting CFLAGS on the "configure" or "make" command > >> >line? This is the standard way to do this with Automake and Autoconf. > >> > > >> > >> Sure

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-04-02 Thread Kavanagh, Mark B
>On 04/01/15 at 07:45am, Kavanagh, Mark B wrote: >> >> >What's wrong with setting CFLAGS on the "configure" or "make" command >> >line? This is the standard way to do this with Automake and Autoconf. >> > >> >> Sure. However, setting CFLAGS on the command line overwrites any values >> CFLAGS has

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-04-01 Thread Ben Pfaff
On Thu, Apr 02, 2015 at 12:41:53AM +0200, Thomas Graf wrote: > On 04/01/15 at 08:06am, Ben Pfaff wrote: > > On Wed, Apr 01, 2015 at 11:34:39AM +0200, Thomas Graf wrote: > > > On 04/01/15 at 07:45am, Kavanagh, Mark B wrote: > > > > Agreed; given the precedent set by OVS_ENABLE_WERROR, I figured that

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-04-01 Thread Thomas Graf
On 04/01/15 at 08:06am, Ben Pfaff wrote: > On Wed, Apr 01, 2015 at 11:34:39AM +0200, Thomas Graf wrote: > > On 04/01/15 at 07:45am, Kavanagh, Mark B wrote: > > > Agreed; given the precedent set by OVS_ENABLE_WERROR, I figured that > > > this was the convention. > > > > The only reason this still e

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-04-01 Thread Ben Pfaff
On Wed, Apr 01, 2015 at 07:45:10AM +, Kavanagh, Mark B wrote: > > >On Tue, Mar 31, 2015 at 11:23:32PM +0100, Mark Kavanagh wrote: > >> DPDK 2.0 contains an updated implementation of rte_memcopy, which > >> leverages SSE and AVX instrinsics. In versions of GCC <= 4.8.2, it > >> has been observe

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-04-01 Thread Ben Pfaff
On Wed, Apr 01, 2015 at 11:34:39AM +0200, Thomas Graf wrote: > On 04/01/15 at 07:45am, Kavanagh, Mark B wrote: > > Agreed; given the precedent set by OVS_ENABLE_WERROR, I figured that > > this was the convention. > > The only reason this still exists is for backwards compatibility > to not break e

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-04-01 Thread Thomas Graf
On 04/01/15 at 07:45am, Kavanagh, Mark B wrote: > > >What's wrong with setting CFLAGS on the "configure" or "make" command > >line? This is the standard way to do this with Automake and Autoconf. > > > > Sure. However, setting CFLAGS on the command line overwrites any values > CFLAGS has attain

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-04-01 Thread Kavanagh, Mark B
>On Tue, Mar 31, 2015 at 11:23:32PM +0100, Mark Kavanagh wrote: >> DPDK 2.0 contains an updated implementation of rte_memcopy, which >> leverages SSE and AVX instrinsics. In versions of GCC <= 4.8.2, it >> has been observed that the relevant instrinsics are not defined in >> gcc headers, resulting

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 11:23:32PM +0100, Mark Kavanagh wrote: > DPDK 2.0 contains an updated implementation of rte_memcopy, which > leverages SSE and AVX instrinsics. In versions of GCC <= 4.8.2, it > has been observed that the relevant instrinsics are not defined in > gcc headers, resulting in co

[ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions <=4.8.2

2015-03-31 Thread Mark Kavanagh
DPDK 2.0 contains an updated implementation of rte_memcopy, which leverages SSE and AVX instrinsics. In versions of GCC <= 4.8.2, it has been observed that the relevant instrinsics are not defined in gcc headers, resulting in compile-time errors. This issue is resolved by enabling the 'mssse3' flag