On Tue, Mar 06, 2012 at 02:37:29PM -0800, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
It looks good to me, but as in a previous patch i would change:
> +if (netdev_dev->cache_valid & VALID_FEATURES) {
> +goto out;
> +}
> +
> +netdev_linux_read_features(netdev_dev);
On Wed, Mar 07, 2012 at 10:58:34AM -0800, Pravin Shelar wrote:
> On Wed, Mar 7, 2012 at 10:39 AM, Ben Pfaff wrote:
> > On Tue, Mar 06, 2012 at 02:37:29PM -0800, Pravin B Shelar wrote:
> >> Signed-off-by: Pravin B Shelar
> >
> > Did you check whether we can cache this stuff? That is, if any of th
On Wed, Mar 7, 2012 at 10:39 AM, Ben Pfaff wrote:
> On Tue, Mar 06, 2012 at 02:37:29PM -0800, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>
> Did you check whether we can cache this stuff? That is, if any of the
> relevant data changes, do we get a Netlink notification for the
> dev
On Tue, Mar 06, 2012 at 02:37:29PM -0800, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
Did you check whether we can cache this stuff? That is, if any of the
relevant data changes, do we get a Netlink notification for the
device? I have my doubts about that, because none of this data
Signed-off-by: Pravin B Shelar
---
lib/netdev-linux.c | 123 ---
1 files changed, 77 insertions(+), 46 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index cfa66f5..2619509 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.
