On Tue, Mar 06, 2012 at 02:37:29PM -0800, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar <[email protected]>
It looks good to me, but as in a previous patch i would change:
> + if (netdev_dev->cache_valid & VALID_FEATURES) {
> + goto out;
> + }
> +
> + netdev_linux_read_features(netdev_dev);
> +
> +out:
to
if (!(netdev_dev->cache_value & VALID_FEATURES)) {
netdev_linux_read_features(netdev_dev);
}
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
