Re: [ovs-dev] [PATCH 4/7] lib/netdev-windows.c: add code to query netdev information

2014-10-04 Thread Nithin Raju
On Oct 3, 2014, at 5:04 PM, Ankur Sharma mailto:ankursha...@vmware.com>> wrote: Hi, Sorry i have a few minor comments in this patch. a. There is a whitespace error: Applying: lib/netdev-windows.c: add code to query netdev information /home/ankur/Desktop/Studies/Codes/ovs_github_review/.git/reba

Re: [ovs-dev] [PATCH 4/7] lib/netdev-windows.c: add code to query netdev information

2014-10-03 Thread Ankur Sharma
Hi, Sorry i have a few minor comments in this patch. a. There is a whitespace error: Applying: lib/netdev-windows.c: add code to query netdev information /home/ankur/Desktop/Studies/Codes/ovs_github_review/.git/rebase-apply/patch:14: trailing whitespace. static int query_netdev(const char *devna

Re: [ovs-dev] [PATCH 4/7] lib/netdev-windows.c: add code to query netdev information

2014-10-03 Thread Ankur Sharma
Acked-by: Ankur Sharma From: Nithin Raju Sent: Friday, October 3, 2014 4:55 PM To: Ankur Sharma Subject: Fwd: [PATCH 4/7] lib/netdev-windows.c: add code to query netdev information Begin forwarded message: From: Nithin Raju mailto:nit...@vmware.com>> Subject:

[ovs-dev] [PATCH 4/7] lib/netdev-windows.c: add code to query netdev information

2014-09-30 Thread Nithin Raju
Primary goals of netdev-windows.c are: 1) To query the 'network device' information of a vport such as MTU, etc. 2) Monitor changes to the 'network device' information such as link status. In this change, we implement only #1. #2 can also be implemented, but it does not seem to be required for t