Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-05-06 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On May 2, 2013, at 21:19 , ext Ben Pfaff wrote: > On Tue, Apr 30, 2013 at 05:21:28AM +, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> >> On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote: >> >>> On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo) >>> wrote: Anot

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-05-02 Thread Ben Pfaff
On Tue, Apr 30, 2013 at 05:21:28AM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote: > > > On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo) > > wrote: > >> > >> Another thing that I came to think only when reading Ben's ne

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-05-02 Thread Ben Pfaff
On Mon, Apr 29, 2013 at 10:49:35AM -0700, Jesse Gross wrote: > On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: > > Another thing that I came to think only when reading Ben's new tutorial: > > Output to the input port is skipped. This would be a problem if you only > >

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-05-02 Thread Jesse Gross
On Thu, May 2, 2013 at 12:59 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Apr 30, 2013, at 18:54 , ext Jesse Gross wrote: > >> On Mon, Apr 29, 2013 at 10:21 PM, Rajahalme, Jarno (NSN - FI/Espoo) >> wrote: >>> >>> On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote: >>> On Sun, Apr 28, 2

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-05-02 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Apr 30, 2013, at 18:54 , ext Jesse Gross wrote: > On Mon, Apr 29, 2013 at 10:21 PM, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> >> On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote: >> >>> On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo) >>> wrote: Another t

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-04-30 Thread Jesse Gross
On Mon, Apr 29, 2013 at 10:21 PM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote: > >> On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo) >> wrote: >>> >>> Another thing that I came to think only when reading Ben's new tutorial: >>>

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-04-29 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Apr 29, 2013, at 20:49 , ext Jesse Gross wrote: > On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo) > wrote: >> >> Another thing that I came to think only when reading Ben's new tutorial: >> Output to the input port is skipped. This would be a problem if you only >> have on

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-04-29 Thread Jesse Gross
On Sun, Apr 28, 2013 at 11:01 PM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > Note to self: It might be prudent to consider carrying and decrementing > the tunnel ttl from a tunnel input to tunnel output to cut out possible loops, > at least in this case of forwarding back to flow-based tunnel inpu

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-04-29 Thread Jesse Gross
On Sun, Apr 28, 2013 at 11:29 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > On Apr 27, 2013, at 0:43 , ext Jesse Gross wrote: >> On Thu, Apr 18, 2013 at 8:07 AM, Jarno Rajahalme >> wrote: >>> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c >>> index 33b09c6..b88a2d4 100644 >>> --- a

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-04-28 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Apr 28, 2013, at 21:29 , ext Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Apr 27, 2013, at 0:43 , ext Jesse Gross wrote: > >> On Thu, Apr 18, 2013 at 8:07 AM, Jarno Rajahalme >> wrote: >>> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c >>> index 33b09c6..b88a2d4 100644 >>> -

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-04-28 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Apr 27, 2013, at 0:43 , ext Jesse Gross wrote: > On Thu, Apr 18, 2013 at 8:07 AM, Jarno Rajahalme > wrote: >> diff --git a/lib/match.c b/lib/match.c >> index 2aa4e89..222e5d7 100644 >> --- a/lib/match.c >> +++ b/lib/match.c >> @@ -133,13 +133,9 @@ match_wc_init(struct match *match, const stru

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-04-26 Thread Jesse Gross
On Thu, Apr 18, 2013 at 8:07 AM, Jarno Rajahalme wrote: > diff --git a/lib/match.c b/lib/match.c > index 2aa4e89..222e5d7 100644 > --- a/lib/match.c > +++ b/lib/match.c > @@ -133,13 +133,9 @@ match_wc_init(struct match *match, const struct flow > *flow) > void > match_init_exact(struct match *m

Re: [ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-04-24 Thread Ben Pfaff
On Thu, Apr 18, 2013 at 06:07:42PM +0300, Jarno Rajahalme wrote: > Do not clear tunnel metadata on tunnel input. This is used by a later patch. > > Signed-off-by: Jarno Rajahalme Jesse, I *think* this patch is OK, but we have a history of subtle bugs here, see commit ef506a7c003232 (ofproto-dpif

[ovs-dev] [PATCH 4/7] Keep all of tunnel metadata in flow.

2013-04-18 Thread Jarno Rajahalme
Do not clear tunnel metadata on tunnel input. This is used by a later patch. Signed-off-by: Jarno Rajahalme --- lib/match.c|4 ofproto/ofproto-dpif.c | 26 -- ofproto/tunnel.c |3 +-- 3 files changed, 13 insertions(+), 20 deletions(-) dif