Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-21 Thread Ben Pfaff
On Mon, Oct 21, 2013 at 09:40:58AM -0700, Jarno Rajahalme wrote: > I went along with the direction of allowing these actions only for > IPv4, as the spec says. This brings difficulties down the road, > however. Basically it becomes impossible to translate between these > set actions and the OF 1.2+

Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-21 Thread Jarno Rajahalme
On Oct 17, 2013, at 3:02 PM, Ben Pfaff wrote: > On Thu, Oct 17, 2013 at 02:59:07PM -0700, Jarno Rajahalme wrote: >> >> On Oct 17, 2013, at 11:47 AM, Ben Pfaff wrote: >> >>> On Wed, Oct 16, 2013 at 04:16:05PM -0700, Jarno Rajahalme wrote: Signed-off-by: Jarno Rajahalme >>> >>> This rais

Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-17 Thread Jarno Rajahalme
On Oct 17, 2013, at 11:47 AM, Ben Pfaff wrote: > On Wed, Oct 16, 2013 at 04:16:05PM -0700, Jarno Rajahalme wrote: >> Signed-off-by: Jarno Rajahalme > > This raises an issue that I had resolved one way, and you resolved > another (even if you did not realize it). I am not certain that I chose

Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-17 Thread Ben Pfaff
On Thu, Oct 17, 2013 at 02:59:07PM -0700, Jarno Rajahalme wrote: > > On Oct 17, 2013, at 11:47 AM, Ben Pfaff wrote: > > > On Wed, Oct 16, 2013 at 04:16:05PM -0700, Jarno Rajahalme wrote: > >> Signed-off-by: Jarno Rajahalme > > > > This raises an issue that I had resolved one way, and you resol

Re: [ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-17 Thread Ben Pfaff
On Wed, Oct 16, 2013 at 04:16:05PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme This raises an issue that I had resolved one way, and you resolved another (even if you did not realize it). I am not certain that I chose the right way, so let me present the issue for discussion.

[ovs-dev] [PATCH 3/9] Add OF11 set IP ECN action.

2013-10-16 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- lib/ofp-actions.c| 24 lib/ofp-actions.h|9 + lib/ofp-parse.c | 14 +- lib/ofp-util.def |2 +- ofproto/ofproto-dpif-xlate.c |8 tests/ovs-ofctl