Re: [ovs-dev] [PATCH 3/6] ovs-xapi-sync: Add unixctl support.

2012-03-08 Thread Ethan Jackson
> It looks weird cause it's a bug.  The condition should be before the > block.  I'll update both patches. Actually, I only made the mistake in this patch. The other one is fine. Ethan ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mai

Re: [ovs-dev] [PATCH 3/6] ovs-xapi-sync: Add unixctl support.

2012-03-08 Thread Ethan Jackson
> looks really weird to me, because it calls immediate_wake() on a > Poller instance that is never afterward used (presumably it gets > garbage collected). It looks weird cause it's a bug. The condition should be before the block. I'll update both patches. Ethan

Re: [ovs-dev] [PATCH 3/6] ovs-xapi-sync: Add unixctl support.

2012-03-08 Thread Ben Pfaff
On Wed, Mar 07, 2012 at 05:09:24PM -0800, Ethan Jackson wrote: > With this patch, users can query a running ovs-xapi-sync's version > or ask it to exit using ovs-appctl. > > Signed-off-by: Ethan Jackson This code: poller = ovs.poller.Poller() unixctl_server.wait(poller)

[ovs-dev] [PATCH 3/6] ovs-xapi-sync: Add unixctl support.

2012-03-07 Thread Ethan Jackson
With this patch, users can query a running ovs-xapi-sync's version or ask it to exit using ovs-appctl. Signed-off-by: Ethan Jackson --- .../usr_share_openvswitch_scripts_ovs-xapi-sync| 25 +++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/xenserver/usr_shar