Re: [ovs-dev] [PATCH 3/3] clang: Fix the alignment warning.

2013-07-22 Thread Alex Wang
Thanks Ben, for the review, > Signed-off-by: Alex Wang > > Could you use the existing ofpbuf_at() instead of a new > ofpbuf_forward_ref()? If there's no appropriate 'size' in a given > call then you can use 0. > > It shouldn't be necessary to cast the return value of > ofpbuf_forward_ref() or o

Re: [ovs-dev] [PATCH 3/3] clang: Fix the alignment warning.

2013-07-22 Thread Ben Pfaff
On Mon, Jul 22, 2013 at 09:19:58AM -0700, Alex Wang wrote: > This commit fixes the warning issued by 'clang' when pointer is casted > to one with greater alignment. > > Signed-off-by: Alex Wang Could you use the existing ofpbuf_at() instead of a new ofpbuf_forward_ref()? If there's no appropria

[ovs-dev] [PATCH 3/3] clang: Fix the alignment warning.

2013-07-22 Thread Alex Wang
This commit fixes the warning issued by 'clang' when pointer is casted to one with greater alignment. Signed-off-by: Alex Wang --- lib/hash.c |6 +++--- lib/jhash.c| 10 +- lib/mac-learning.c |4 ++-- lib/netdev-linux.c |3 ++- lib/netlink.c