Thanks Ben, for the review,

> Signed-off-by: Alex Wang <al...@nicira.com>
>
> Could you use the existing ofpbuf_at() instead of a new
> ofpbuf_forward_ref()?  If there's no appropriate 'size' in a given
> call then you can use 0.
>
> It shouldn't be necessary to cast the return value of
> ofpbuf_forward_ref() or ofpbuf_at(), generally, because they return
> void *.
>

I should have found and used ofpbuf_at(). Thanks for pointing out,


It isn't necessary to parenthesize the arguments to ALIGNED_CAST,
> since the macro properly parenthesizes them internally.
>

I'll adjust accordingly,
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to