Re: [ovs-dev] [PATCH 2/6] revalidator: Don't modify ukey from xlate_ukey().

2016-09-28 Thread Joe Stringer
On 28 September 2016 at 14:22, Daniele Di Proietto wrote: > Is there any reason not to squash this with the previous patch? It was an attempt at separating functional changes from cosmetic. > If you want to keep two commits for clarity I would split it like: > > commit1) move the block above odp

Re: [ovs-dev] [PATCH 2/6] revalidator: Don't modify ukey from xlate_ukey().

2016-09-28 Thread Daniele Di Proietto
Is there any reason not to squash this with the previous patch? If you want to keep two commits for clarity I would split it like: commit1) move the block above odp_flow_key_to_flow() commit2) factor out xlate_ukey() in the second. 2016-09-20 18:47 GMT-07:00 Joe Stringer : > Refactor the newly

[ovs-dev] [PATCH 2/6] revalidator: Don't modify ukey from xlate_ukey().

2016-09-20 Thread Joe Stringer
Refactor the newly introduced xlate_ukey() function to just perform the translation, not modify the ukey. Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/ofproto/ofproto-dpif-upca