Re: [ovs-dev] [PATCH 2/3] timeval: Coalesce backtraces with counts.

2012-10-25 Thread Ethan Jackson
Thanks for the reviews, I'll merge this series shortly. Ethan On Thu, Oct 25, 2012 at 1:13 PM, Ben Pfaff wrote: > On Thu, Oct 25, 2012 at 10:06:26AM -0700, Ethan Jackson wrote: >> Making stubs turned out to be cleanest. Here's an incremental. > > Looks good to me, thanks. __

Re: [ovs-dev] [PATCH 2/3] timeval: Coalesce backtraces with counts.

2012-10-25 Thread Ben Pfaff
On Thu, Oct 25, 2012 at 10:06:26AM -0700, Ethan Jackson wrote: > Making stubs turned out to be cleanest. Here's an incremental. Looks good to me, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/3] timeval: Coalesce backtraces with counts.

2012-10-25 Thread Ethan Jackson
Making stubs turned out to be cleanest. Here's an incremental. --- lib/timeval.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/lib/timeval.c b/lib/timeval.c index bd2a84d..b36203a 100644 --- a/lib/timeval.c +++ b/lib/timeval.c @@ -39,10 +39,

Re: [ovs-dev] [PATCH 2/3] timeval: Coalesce backtraces with counts.

2012-10-24 Thread Ben Pfaff
On Wed, Oct 24, 2012 at 01:49:08PM -0700, Ethan Jackson wrote: > With this patch, `ovs-appctl backtrace` will return a unique list > of backtraces and a count of how many times it has been recorded. > This work had previously been done by ovs-parse-backtrace. However, > in future patches poll-loop

[ovs-dev] [PATCH 2/3] timeval: Coalesce backtraces with counts.

2012-10-24 Thread Ethan Jackson
With this patch, `ovs-appctl backtrace` will return a unique list of backtraces and a count of how many times it has been recorded. This work had previously been done by ovs-parse-backtrace. However, in future patches poll-loop will begin logging backtraces as a matter of course. At this point, co