Re: [ovs-dev] [PATCH 2/3] datapath: Add support for OVS_FLOW_ATTR_SILENT.

2014-09-11 Thread Jarno Rajahalme
On Sep 11, 2014, at 4:23 PM, Pravin Shelar wrote: > On Wed, Sep 10, 2014 at 2:06 PM, Jarno Rajahalme > wrote: >> This new flag is useful for suppressing error logging when error >> messages may be expected, as when probing for datapath features using >> flow commands. >> (snip) >> diff --gi

Re: [ovs-dev] [PATCH 2/3] datapath: Add support for OVS_FLOW_ATTR_SILENT.

2014-09-11 Thread Pravin Shelar
On Wed, Sep 10, 2014 at 2:06 PM, Jarno Rajahalme wrote: > This new flag is useful for suppressing error logging when error > messages may be expected, as when probing for datapath features using > flow commands. > > Signed-off-by: Jarno Rajahalme > --- > datapath/datapath.c

Re: [ovs-dev] [PATCH 2/3] datapath: Add support for OVS_FLOW_ATTR_SILENT.

2014-09-11 Thread Andy Zhou
It looks good overall. Thanks for working on this. Signed-off-by: Andy Zhou I have a few minor comments: In datapatch.c, should we extend flow_policy[] for the new flow attributes? It seems OVS_fLOW_ATTR_MASK is also missing -- may be good to fix that also. in flow_netlink.c for function ovs_n

[ovs-dev] [PATCH 2/3] datapath: Add support for OVS_FLOW_ATTR_SILENT.

2014-09-10 Thread Jarno Rajahalme
This new flag is useful for suppressing error logging when error messages may be expected, as when probing for datapath features using flow commands. Signed-off-by: Jarno Rajahalme --- datapath/datapath.c | 26 +-- datapath/datapath.h