Re: [ovs-dev] [PATCH 2/3] Delete groups in ofproto_destruct.

2013-09-01 Thread Simon Horman
On Sun, Sep 01, 2013 at 06:24:39PM -0700, Ben Pfaff wrote: > On Sat, Aug 31, 2013 at 02:11:39PM +0900, Simon Horman wrote: > > On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote: > > > Also, since all kinds of groups can refer to other groups, there is no > > > reason to delete indirec

Re: [ovs-dev] [PATCH 2/3] Delete groups in ofproto_destruct.

2013-09-01 Thread Ben Pfaff
On Sat, Aug 31, 2013 at 02:11:39PM +0900, Simon Horman wrote: > On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote: > > Also, since all kinds of groups can refer to other groups, there is no > > reason to delete indirect groups first. > > This seems reasonable to me, but its not clear

Re: [ovs-dev] [PATCH 2/3] Delete groups in ofproto_destruct.

2013-09-01 Thread Ben Pfaff
On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote: > Also, since all kinds of groups can refer to other groups, there is no > reason to delete indirect groups first. > > Signed-off-by: Jarno Rajahalme I folded this in, thanks. I've now added you as a co-author, also. _

Re: [ovs-dev] [PATCH 2/3] Delete groups in ofproto_destruct.

2013-08-30 Thread Simon Horman
On Fri, Aug 30, 2013 at 01:40:17PM -0700, Jarno Rajahalme wrote: > Also, since all kinds of groups can refer to other groups, there is no > reason to delete indirect groups first. This seems reasonable to me, but its not clear to me how the code prevents the deletion of groups that are still refer

[ovs-dev] [PATCH 2/3] Delete groups in ofproto_destruct.

2013-08-30 Thread Jarno Rajahalme
Also, since all kinds of groups can refer to other groups, there is no reason to delete indirect groups first. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c in