> Minor variants in comment style, like whether the /* and */ are on
> lines by themselves, just don't bother me much, which is why
> CodingStyle says, "You may put the /* and */ on the same line as
> comment text if you prefer." I normally write them on the same line,
> so that's probably why a l
On Fri, Jan 27, 2012 at 02:15:18PM -0800, Ethan Jackson wrote:
> However, the CodingStyle document says to write comments the way that
> you've done in this patch. Ben, is there a particular reason for the
> way the CodingStyle document says to write block comments? If not,
> I'd be inclined to c
> +/*
> + * Writes the time 'tm' to 'string' based on 'template'. A Null 'tm'
> + * writes the current utc time or localtime to 'string' based on 'utc'
> + */
Two minor nits. First, this comment requieres a period at the end of
the second sentence.
Second. In most of the code we don't do a newl
On Fri, Jan 27, 2012 at 11:39:15AM -0800, Gurucharan Shetty wrote:
> Change the default timestamp for console and file logs to
> UTC in a format that satisfies timestamp requirements in RFC 5424.
>
> Also, add the ability for ovs-appctl to log timestamps in UTC.
>
> Bug #9052.
>
> Signed-off-by:
Change the default timestamp for console and file logs to
UTC in a format that satisfies timestamp requirements in RFC 5424.
Also, add the ability for ovs-appctl to log timestamps in UTC.
Bug #9052.
Signed-off-by: Gurucharan Shetty
---
lib/dynamic-string.c | 13 +++--
lib/dynami
