> +/* > + * Writes the time 'tm' to 'string' based on 'template'. A Null 'tm' > + * writes the current utc time or localtime to 'string' based on 'utc' > + */
Two minor nits. First, this comment requieres a period at the end of the second sentence. Second. In most of the code we don't do a newline after the opening /* in block comments, and we dont' require a newline before the closing */. e.g. like the following: /* Writes the time 'tm' to 'string' based on 'template'. A Null 'tm' * writes the current utc time or localtime to 'string' based on 'utc'. */ However, the CodingStyle document says to write comments the way that you've done in this patch. Ben, is there a particular reason for the way the CodingStyle document says to write block comments? If not, I'd be inclined to change it to what we typically have done throughout the code. Ethan _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
