Re: [ovs-dev] [PATCH 2/2] sflow: Use ofproto_port_get_stats().

2011-12-02 Thread Ben Pfaff
This seems reasonable but I see ways to improve it. The 'netdev' member can now be removed from struct dpif_sflow_port since it can get the same netdev as ofport->netdev. The 'odp_port' member can also be removed since it can be calculated using ofp_port_to_odp_port(ofport->ofp_port). Also, in a

[ovs-dev] [PATCH 2/2] sflow: Use ofproto_port_get_stats().

2011-12-02 Thread Pravin B Shelar
--- ofproto/ofproto-dpif-sflow.c |8 +--- ofproto/ofproto-dpif-sflow.h |3 ++- ofproto/ofproto-dpif.c |5 +++-- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto-dpif-sflow.c b/ofproto/ofproto-dpif-sflow.c index d17b0be..73faf03 100644 --- a/ofpr