Re: [ovs-dev] [PATCH 2/2] ovn-nbctl: Add ACL commands.

2015-09-10 Thread Ben Pfaff
On Thu, Sep 10, 2015 at 02:07:54PM -0700, Justin Pettit wrote: > > > On Sep 5, 2015, at 4:53 PM, Ben Pfaff wrote: > > > > -printf("%10s %5ld (%s) %s%s\n", acl->direction, acl->priority, > > +printf("%10s %5"PRId64" (%s) %s%s\n", acl->direction, > > acl->priority, > > Fixed. >

Re: [ovs-dev] [PATCH 2/2] ovn-nbctl: Add ACL commands.

2015-09-10 Thread Justin Pettit
> On Sep 5, 2015, at 4:53 PM, Ben Pfaff wrote: > > -printf("%10s %5ld (%s) %s%s\n", acl->direction, acl->priority, > +printf("%10s %5"PRId64" (%s) %s%s\n", acl->direction, acl->priority, Fixed. > I'd prefer to avoid casts in acl_cmp(), also the macro there doesn't > seem to hel

Re: [ovs-dev] [PATCH 2/2] ovn-nbctl: Add ACL commands.

2015-09-05 Thread Ben Pfaff
On Fri, Sep 04, 2015 at 05:39:02PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit I came really close to duplicating your work here on Thursday when I was writing tests. I'm glad that didn't happen. The printf() specifier is wrong here: diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/

[ovs-dev] [PATCH 2/2] ovn-nbctl: Add ACL commands.

2015-09-04 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ovn/utilities/ovn-nbctl.8.xml | 28 + ovn/utilities/ovn-nbctl.c | 242 + tests/ovn-nbctl.at| 49 3 files changed, 319 insertions(+), 0 deletions(-) diff --git a/ovn/utilities/ovn-nbctl.8.xm