> On Sep 5, 2015, at 4:53 PM, Ben Pfaff <b...@nicira.com> wrote: > > - printf("%10s %5ld (%s) %s%s\n", acl->direction, acl->priority, > + printf("%10s %5"PRId64" (%s) %s%s\n", acl->direction, acl->priority,
Fixed. > I'd prefer to avoid casts in acl_cmp(), also the macro there doesn't > seem to help much: This is better. Thanks. > + if (dir1 != dir2) { > + return dir1 > dir2 ? -1 : 1; I changed this to "<", so that it would sort from smallest to largest, which means "from-lport" comes before "to-lport". > Acked-by: Ben Pfaff <b...@nicira.com> Thanks. Assuming you agree with the above change, I'll keep this ack. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev