Re: [ovs-dev] [PATCH 2/2] odp-util: Move commit_odp_actions() from ofproto-dpif.

2011-11-28 Thread Ethan Jackson
Sounds fine to me. I've changed the comment and will push this soon. Ethan On Mon, Nov 28, 2011 at 15:40, Ben Pfaff wrote: > On Mon, Nov 28, 2011 at 02:43:15PM -0800, Ethan Jackson wrote: >> In an effort to simplify ofproto-dpif, this commit moves the >> definition of commit_odp_actions() to od

Re: [ovs-dev] [PATCH 2/2] odp-util: Move commit_odp_actions() from ofproto-dpif.

2011-11-28 Thread Ben Pfaff
On Mon, Nov 28, 2011 at 02:43:15PM -0800, Ethan Jackson wrote: > In an effort to simplify ofproto-dpif, this commit moves the > definition of commit_odp_actions() to odp-util. I think that we could improve the comment on commit_odp_actions(). Something like this: If any of the flow key data t

[ovs-dev] [PATCH 2/2] odp-util: Move commit_odp_actions() from ofproto-dpif.

2011-11-28 Thread Ethan Jackson
In an effort to simplify ofproto-dpif, this commit moves the definition of commit_odp_actions() to odp-util. --- lib/odp-util.c | 160 +++ lib/odp-util.h |3 + ofproto/ofproto-dpif.c | 163 +--