Sounds fine to me. I've changed the comment and will push this soon. Ethan
On Mon, Nov 28, 2011 at 15:40, Ben Pfaff <b...@nicira.com> wrote: > On Mon, Nov 28, 2011 at 02:43:15PM -0800, Ethan Jackson wrote: >> In an effort to simplify ofproto-dpif, this commit moves the >> definition of commit_odp_actions() to odp-util. > > I think that we could improve the comment on commit_odp_actions(). > Something like this: > > If any of the flow key data that ODP actions can modify are > different in 'base' and 'flow', appends ODP actions to > 'odp_actions' that change the flow key from 'base' into 'flow', > and then changes 'base' the same way. > > Thanks, > > Ben. > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
