I will send out V3 that returns false, and move the logic back to
ovs_key_from_nlattrs(). Userspace fixes, if any, needs to have its own
patch.
On Mon, Jul 29, 2013 at 1:29 PM, Jesse Gross wrote:
> On Mon, Jul 29, 2013 at 1:27 PM, Jesse Gross wrote:
> > On Mon, Jul 29, 2013 at 12:44 PM, Andy Z
On Mon, Jul 29, 2013 at 1:27 PM, Jesse Gross wrote:
> On Mon, Jul 29, 2013 at 12:44 PM, Andy Zhou wrote:
>> On Mon, Jul 29, 2013 at 10:32 AM, Jesse Gross wrote:
>>>
>>> On Sat, Jul 27, 2013 at 10:27 PM, Andy Zhou wrote:
>>> > diff --git a/datapath/flow.c b/datapath/flow.c
>>> > index ba775f4..5
On Mon, Jul 29, 2013 at 12:44 PM, Andy Zhou wrote:
> On Mon, Jul 29, 2013 at 10:32 AM, Jesse Gross wrote:
>>
>> On Sat, Jul 27, 2013 at 10:27 PM, Andy Zhou wrote:
>> > diff --git a/datapath/flow.c b/datapath/flow.c
>> > index ba775f4..5ec1b69 100644
>> > --- a/datapath/flow.c
>> > +++ b/datapath
When we were previously doing just exact match, 'no-port' still
existed and it obviously wasn't a wildcard so I don't think that it
inherently means one now.
When the in port value is omitted, we currently allow you to omit the
mask or have either an all zeros or all ones mask so userspace should
On Mon, Jul 29, 2013 at 10:32 AM, Jesse Gross wrote:
> On Sat, Jul 27, 2013 at 10:27 PM, Andy Zhou wrote:
> > diff --git a/datapath/flow.c b/datapath/flow.c
> > index ba775f4..5ec1b69 100644
> > --- a/datapath/flow.c
> > +++ b/datapath/flow.c
> > @@ -224,6 +224,15 @@ static bool ovs_match_valida
Should 'no-port' be treated as wildcarded match on in_port?
On Mon, Jul 29, 2013 at 11:31 AM, Jesse Gross wrote:
> On Mon, Jul 29, 2013 at 10:32 AM, Jesse Gross wrote:
> > On Sat, Jul 27, 2013 at 10:27 PM, Andy Zhou wrote:
> >> @@ -1317,6 +1326,7 @@ static int metadata_from_nlattrs(struct
> s
On Mon, Jul 29, 2013 at 10:32 AM, Jesse Gross wrote:
> On Sat, Jul 27, 2013 at 10:27 PM, Andy Zhou wrote:
>> @@ -1317,6 +1326,7 @@ static int metadata_from_nlattrs(struct sw_flow_match
>> *match, u64 *attrs,
>> *attrs &= ~(1ULL << OVS_KEY_ATTR_IN_PORT);
>> } else if (!is
On Sat, Jul 27, 2013 at 10:27 PM, Andy Zhou wrote:
> diff --git a/datapath/flow.c b/datapath/flow.c
> index ba775f4..5ec1b69 100644
> --- a/datapath/flow.c
> +++ b/datapath/flow.c
> @@ -224,6 +224,15 @@ static bool ovs_match_validate(const struct
> sw_flow_match *match,
> return f
Missing VLAN netlink attribute should be interpreted as exact match
of no VLAN tag, instead of wildcarded match for all VLAN tags.
Bug #18736.
Signed-off-by: Andy Zhou
---
datapath/flow.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/datapath/flow.c b/datap
