On Mon, Jul 29, 2013 at 1:27 PM, Jesse Gross <je...@nicira.com> wrote:
> On Mon, Jul 29, 2013 at 12:44 PM, Andy Zhou <az...@nicira.com> wrote:
>> On Mon, Jul 29, 2013 at 10:32 AM, Jesse Gross <je...@nicira.com> wrote:
>>>
>>> On Sat, Jul 27, 2013 at 10:27 PM, Andy Zhou <az...@nicira.com> wrote:
>>> > diff --git a/datapath/flow.c b/datapath/flow.c
>>> > index ba775f4..5ec1b69 100644
>>> > --- a/datapath/flow.c
>>> > +++ b/datapath/flow.c
>>> > @@ -224,6 +224,15 @@ static bool ovs_match_validate(const struct
>>> > sw_flow_match *match,
>>> > return false;
>>> > }
>>> >
>>> > + if (match->mask &&
>>> > + !(match->mask->key.eth.tci & htons(VLAN_TAG_PRESENT))) {
>>> > + OVS_NLERR("VLAN present bit can not be
>>> > wildcarded.\n");
>>> > + /* Simply log error until user the space program
>>> > is
>>> > + * fixed. Then we can switch to return false
>>> > from
>>> > + * here.
>>> > + */
>>> > + }
>>>
>>> Can we just fix this? We already force the bit on for the value in
>>> userspace, it seems like we could do it for the mask at the same time.
>>
>>
>> We could, but I was hopping to return an error from here eventually.
>
> I'm not sure that I understand. I was just referring to fixing the
> issue that you mentioned in the comment now rather than later.
OK, I understand what you meant now that I see the new version of the
patch. I meant fixing userspace.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
