On Aug 29, 2011, at 7:17 AM, Jesse Gross wrote:
> On Aug 29, 2011 3:56 PM, "Justin Pettit" wrote:
> > diff --git a/datapath/linux/compat/include/linux/netdevice.h
> > b/datapath/linux/compat/include/linux/netdevice.h
> > index 04ebd89..664ff2e 100644
> > --- a/datapath/linux/compat/include/linux
On Aug 29, 2011 3:56 PM, "Justin Pettit" wrote:
> diff --git a/datapath/linux/compat/include/linux/netdevice.h
b/datapath/linux/compat/include/linux/netdevice.h
> index 04ebd89..664ff2e 100644
> --- a/datapath/linux/compat/include/linux/netdevice.h
> +++ b/datapath/linux/compat/include/linux/netde
Whenever a port is added to the datapath, LRO is automatically disabled.
In the future, we may want to enable LRO in some circumstances, so have
userspace disable LRO through the ethtool ioctls.
As part of this change, the MTU and LRO checks are moved to
netdev-vport's send(), which is where they'
On Aug 27, 2011, at 6:59 AM, Jesse Gross wrote:
> What I'm thinking about is what happens when we actually implement
> this optimization, assuming that the userspace/kernel interface is
> locked down. When userspace stops disabling LRO, these checks will
> start triggering and will drop packets.
On Sat, Aug 27, 2011 at 3:56 PM, Justin Pettit wrote:
> On Aug 19, 2011, at 8:39 PM, Jesse Gross wrote:
>
>> The final piece that I just thought of, is the relationship of the MTU
>> check in vport_send() and skb_warn_if_lro(). The former will catch
>> hardware LRO and interfaces with mismatched
On Aug 19, 2011, at 8:39 PM, Jesse Gross wrote:
> The final piece that I just thought of, is the relationship of the MTU
> check in vport_send() and skb_warn_if_lro(). The former will catch
> hardware LRO and interfaces with mismatched MTU and the later the
> deprecated (but still extant software
On Sat, Aug 20, 2011 at 9:50 AM, Justin Pettit wrote:
> On Aug 18, 2011, at 9:22 PM, Jesse Gross wrote:
>
>> The main thing that I was wondering about in this patch is the implications
>> for the backports in RHEL 5. I looked through some of their patches and it
>> appears that they backported L
On Sat, Aug 20, 2011 at 9:47 AM, Justin Pettit wrote:
>
> On Aug 19, 2011, at 6:13 PM, Jesse Gross wrote:
>
>> On Thu, Aug 18, 2011 at 10:01 AM, Justin Pettit wrote:
>>> @@ -381,6 +386,10 @@ dpif_linux_port_add(struct dpif *dpif_, struct netdev
>>> *netdev,
>>> request.options_len = opti
On Aug 18, 2011, at 9:22 PM, Jesse Gross wrote:
> The main thing that I was wondering about in this patch is the implications
> for the backports in RHEL 5. I looked through some of their patches and it
> appears that they backported LRO (and drivers that enable it) but not the
> userspace inte
On Aug 19, 2011, at 6:13 PM, Jesse Gross wrote:
> On Thu, Aug 18, 2011 at 10:01 AM, Justin Pettit wrote:
>> @@ -381,6 +386,10 @@ dpif_linux_port_add(struct dpif *dpif_, struct netdev
>> *netdev,
>> request.options_len = options->size;
>> }
>>
>> +if (request.type == ODP_VPORT_T
On Thu, Aug 18, 2011 at 10:01 AM, Justin Pettit wrote:
> @@ -381,6 +386,10 @@ dpif_linux_port_add(struct dpif *dpif_, struct netdev
> *netdev,
> request.options_len = options->size;
> }
>
> + if (request.type == ODP_VPORT_TYPE_NETDEV) {
> + netdev_linux_ethtool_set_flag(netd
On Aug 19, 2011 12:54 AM, "Justin Pettit" wrote:
>
> On Aug 18, 2011, at 9:31 AM, Ben Pfaff wrote:
> > Do we need to disable LRO on internal ports too (after we add them)?
>
> The current code doesn't appear to do that, and I don't know if LRO makes
sense without hardware. I'll wait for Jesse's f
On Aug 18, 2011, at 9:31 AM, Ben Pfaff wrote:
> Speaking for userspace code only:
>
> This adds a doubled blank line in dpif-linux.c.
Thanks. Fixed.
> Do we need to disable LRO on internal ports too (after we add them)?
The current code doesn't appear to do that, and I don't know if LRO makes
On Wed, Aug 17, 2011 at 07:01:54PM -0700, Justin Pettit wrote:
> Whenever a port is added to the datapath, LRO is automatically disabled.
> In the future, we may want to enable LRO in some circumstances, so have
> userspace disable LRO through the ethtool ioctls.
>
> Feature #6810
>
> Signed-off-
Whenever a port is added to the datapath, LRO is automatically disabled.
In the future, we may want to enable LRO in some circumstances, so have
userspace disable LRO through the ethtool ioctls.
Feature #6810
Signed-off-by: Justin Pettit
---
datapath/linux/.gitignore |
15 matches
Mail list logo
