Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-21 Thread Simon Horman
On Wed, Mar 20, 2013 at 05:46:38PM -0700, Jesse Gross wrote: > On Wed, Mar 20, 2013 at 5:33 PM, Simon Horman wrote: > > On Wed, Mar 20, 2013 at 03:43:38PM -0700, Jesse Gross wrote: > >> On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > >> > Allow datapath to recognize and extract MPLS labels

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Jesse Gross
On Wed, Mar 20, 2013 at 5:33 PM, Simon Horman wrote: > On Wed, Mar 20, 2013 at 03:43:38PM -0700, Jesse Gross wrote: >> On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: >> > Allow datapath to recognize and extract MPLS labels into flow keys >> > and execute actions which push, pop, and set lab

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Simon Horman
On Wed, Mar 20, 2013 at 03:43:38PM -0700, Jesse Gross wrote: > On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > > Allow datapath to recognize and extract MPLS labels into flow keys > > and execute actions which push, pop, and set labels on packets. > > > > Based heavily on work by Leo Alterm

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Jesse Gross
On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > Allow datapath to recognize and extract MPLS labels into flow keys > and execute actions which push, pop, and set labels on packets. > > Based heavily on work by Leo Alterman and Ravi K. > > Cc: Ravi K > Cc: Leo Alterman > Reviewed-by: Isaku

[ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- TODO: * Enhance core k

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-20 Thread Simon Horman
On Tue, Mar 19, 2013 at 08:16:16AM -0700, Jesse Gross wrote: > On Tue, Mar 19, 2013 at 5:31 AM, Simon Horman wrote: > > On Tue, Mar 19, 2013 at 11:14:58AM +0900, Simon Horman wrote: > >> On Mon, Mar 18, 2013 at 06:35:48PM -0700, Jesse Gross wrote: > >> > On Mon, Mar 18, 2013 at 6:22 PM, Simon Horm

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-19 Thread Jesse Gross
On Tue, Mar 19, 2013 at 5:31 AM, Simon Horman wrote: > On Tue, Mar 19, 2013 at 11:14:58AM +0900, Simon Horman wrote: >> On Mon, Mar 18, 2013 at 06:35:48PM -0700, Jesse Gross wrote: >> > On Mon, Mar 18, 2013 at 6:22 PM, Simon Horman wrote: >> > > On Mon, Mar 18, 2013 at 05:45:52PM -0700, Jesse Gro

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-19 Thread Simon Horman
On Tue, Mar 19, 2013 at 11:14:58AM +0900, Simon Horman wrote: > On Mon, Mar 18, 2013 at 06:35:48PM -0700, Jesse Gross wrote: > > On Mon, Mar 18, 2013 at 6:22 PM, Simon Horman wrote: > > > On Mon, Mar 18, 2013 at 05:45:52PM -0700, Jesse Gross wrote: > > >> I don't think that we want to allow an arr

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Simon Horman
On Mon, Mar 18, 2013 at 06:35:48PM -0700, Jesse Gross wrote: > On Mon, Mar 18, 2013 at 6:22 PM, Simon Horman wrote: > > On Mon, Mar 18, 2013 at 05:45:52PM -0700, Jesse Gross wrote: > >> I don't think that we want to allow an array of MPLS labels at this > >> point in time, since we'll just silentl

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Jesse Gross
On Mon, Mar 18, 2013 at 6:22 PM, Simon Horman wrote: > On Mon, Mar 18, 2013 at 05:45:52PM -0700, Jesse Gross wrote: >> I don't think that we want to allow an array of MPLS labels at this >> point in time, since we'll just silently ignore the ones that we don't >> expect, which isn't good. However

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Simon Horman
On Mon, Mar 18, 2013 at 05:45:52PM -0700, Jesse Gross wrote: > On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: > > Allow datapath to recognize and extract MPLS labels into flow keys > > and execute actions which push, pop, and set labels on packets. > > > > Based heavily on work by Leo Alter

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Jesse Gross
On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: > Allow datapath to recognize and extract MPLS labels into flow keys > and execute actions which push, pop, and set labels on packets. > > Based heavily on work by Leo Alterman and Ravi K. > > Cc: Ravi K > Cc: Leo Alterman > Reviewed-by: Isak

[ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- TODO: * Enhance core k