On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman <ho...@verge.net.au> wrote: > Allow datapath to recognize and extract MPLS labels into flow keys > and execute actions which push, pop, and set labels on packets. > > Based heavily on work by Leo Alterman and Ravi K. > > Cc: Ravi K <rke...@gmail.com> > Cc: Leo Alterman <lalter...@nicira.com> > Reviewed-by: Isaku Yamahata <yamah...@valinux.co.jp> > Signed-off-by: Simon Horman <ho...@verge.net.au> > > --- > > TODO: > * Enhance core kernel code to handle GSO for MPLS or > otherwise deal with accelerations. (Linux network core) > * Add ETH_TYPE_MIN or similar to Linux network core > > v2.22 > * As suggested by Jesse Gross: > - Fix sparse warning in validate_and_copy_actions() > I have no idea why sparse doesn't show this up this on my system. > - Remove call to skb_cow_head() from push_mpls() as it > is already covered by a call to make_writable() > - Check (key_type > OVS_KEY_ATTR_MAX) in ovs_flow_verify_key_len() > - Disallow set actions on l2.5+ data and MPLS push and pop actions > after an MPLS pop action as there is no verification that the packet > is actually of the new ethernet type. This may later be supported > using recirculation or by other means. > - Do not add spurious debuging message to ovs_flow_cmd_new_or_set()
There were a couple other things from the previous time that don't seem to have made it here. Looking back I see: * MPLS label userspace/kernel change (just the type definition) and only allowing a single label in the stack at this time. * Validation of actions using both paths of the sample action. Were you planning on addressing these as well? _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
