Re: [ovs-dev] [PATCH 15/18] implement set_etheraddr for NetBSD

2013-01-31 Thread Ben Pfaff
On Thu, Jan 31, 2013 at 07:49:49PM +0900, YAMAMOTO Takashi wrote: > From: YAMAMOTO Takashi > > Signed-off-by: YAMAMOTO Takashi I see a number of repeated blocks here of the form: > +int saved_errno = errno; > + > +close(s); > +return saved_errno; We would usually put thi

[ovs-dev] [PATCH 15/18] implement set_etheraddr for NetBSD

2013-01-31 Thread YAMAMOTO Takashi
From: YAMAMOTO Takashi Signed-off-by: YAMAMOTO Takashi --- lib/netdev-bsd.c | 76 ++-- 1 file changed, 69 insertions(+), 7 deletions(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 76782ec..615a26f 100644 --- a/lib/netdev-bsd.c +++