hi Alin,
This is a huge change, and I think you and Samuel are on the right track. I
have noted down a few comments. Pls. address them and also the comments from
Eitan and Ankur, and we should be in a good shape.
On Sep 30, 2014, at 7:58 AM, Samuel Ghinet
wrote:
> Does the following:
> a. bef
Adding a few more comments:
a. OvsComputeVportNo should be in Vport.c.
b. OvsNewVportCmdHandler should be moved to Vport.c
c. BuildMsgOut, BuildReplyMsgFromMsgIn and BuildErrorMsg are not Port specific.
We should be generic Netlink APIs (add one if they do not exist).
d. HvOnCreatePort: The scen
I realize this code should handle many cases but it is a good start.
There are three major cases:
[1] Hv port is already exists but OVS port is not. This is the major case but
it seems to me it is not handled correctly. It seems that we need to use the
already created HvName and populate the Ovs
Does the following:
a. before creating the vport, makes sure there is no existing vport
with the same ovs (datapath) port name. If this is not so, it means
that the specified port already exists: it returns NL_ERROR_EXIST.
b. looks up the vport:
o) if the vport type is "internal", then the intern
